Replace hardcoded percentages with values from a file#27
Replace hardcoded percentages with values from a file#27ZuleykhaPavlichenkova-TomTom wants to merge 46 commits intoduckdb:mainfrom
Conversation
Tmonster
left a comment
Tmonster
left a comment
There was a problem hiding this comment.
Looks good! I don't think the RandomsConfig needs to be a friend class, instead you can make the RandomConfig a member of the StatementGenerator. Ie...
class StatementGenerator {
public:
RandomsConfig percentage_selector;
}
…rom the config file
ZuleykhaPavlichenkova-TomTom
force-pushed
the
random-values-from-file
branch
from
00d7930 to
e08843b
Compare
…rkflow directory of the source repo from the reusable_workflows directory
…s and that doesn't make ParseJSONMap parse the string with the new lines
Tmonster
left a comment
Tmonster
left a comment
There was a problem hiding this comment.
Maybe the RandomNumsConfig could be an unorderdered_map<percentages_enum, idx_t> ?
You will have to create an Enum (see duckdb/common/enums/logical_operator_type.hpp for an example).
In the future it will make it easier to manage the percentages, add new ones etc.
…h the wrong json structure or contains an empty {}
Tmonster
left a comment
Tmonster
left a comment
There was a problem hiding this comment.
Looks much better.
looks like you don't use the file handle though.
Now you can start adding more percentages as well if you want. Feel free to create a GitHub actions file that runs the fuzzer with a config file and one without
Tmonster
left a comment
Tmonster
left a comment
There was a problem hiding this comment.
Looks good. Just the one comment.
also, I can imagine you may end up adding many ENUMS for each case. You can also just create enums like RandomPercentagesEnum::DEFAULT_XX_PERCENT so that your enum library doesn't get insanely big. Eventually the enums in the statement generation code can get their own enums as we continue to work on and expand this functionality
2 participants
This PR will replace hardcoded percentages from the fuzzer with values defined in a file, as it mentioned in the #23